Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix octoprint ssl #3718

Closed
wants to merge 2 commits into from
Closed

Fix octoprint ssl #3718

wants to merge 2 commits into from

Conversation

Salandora
Copy link

This is my attempt to fix #3203.

For me it was necessary to disable the hostname check, no matter what I did perl was not able to verify the hostname, not even if I specify the path to the certificates... maybe someone can take a look at this part.

Next was to remove the hard coded http:// and replace it with a regex check, so basically I check if the url starts with http if not http:// will be appended.
But now you can add a https:// in front of the url so that it now gets recognized as a secure connection.

@alranel
Copy link
Member

alranel commented Feb 28, 2017

Net::SSL needs to be added as a dependency in Build.PL and this means we need to include openssl in the builds. Since we're in the process of reworking our builds, let's not add one more dependency for now.

@Salandora
Copy link
Author

Ahh I see okay, well any Idea how to get around Net::SSL?

I will try a few things the next days and report back when I found a solution.

@alranel alranel added this to the 1.3.0 milestone Mar 18, 2017
@lordofhyphens lordofhyphens modified the milestones: 1.3.1, 1.3.0 Mar 28, 2017
@alranel
Copy link
Member

alranel commented May 20, 2017

We're going C++ soon. We can use boost::asio with OpenSSL, but we need to make this dependency optional (i.e. allow people to compile without SSL support).

@lordofhyphens
Copy link
Member

Incorporated into #4795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't connect to octoprint over SSL
3 participants