donotdisturb: fix for GNOME #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Poke? |
deltragon
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GNOME Shell (on Wayland) doesn't work with wlrctl, but there is a DBus property that can be read to see if any application has requested that the screensaver not kick in, so let's use that to suppress SafeEyes breaks too—it's not exactly the same as detecting if the active window is fullscreen, but I actually think it's a little better (if a productivity application is fullscreened, we probably want breaks; if a real-time game is running in a window, we probably don't).
I'm using the Gio interface to DBus instead of dbus-python, per the direction proposed in #558.