Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uses of deprecated gtk3 apis #560

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove uses of deprecated gtk3 apis #560

wants to merge 3 commits into from
+58 −52

Conversation

deltragon
Copy link
Collaborator

Necessary for migration to gtk4.

@deltragon deltragon force-pushed the gtk-deprecations branch 2 times, most recently from 4e0160e to 385c7d5 Compare January 2, 2024 12:16
@deltragon
fix deprecations
f45b83c
@deltragon
port to Gtk.Application
1ebcfa2 
Gtk.main() and Gtk.main_quit() are dropped in gtk4 in favor of
subclassing Gtk.Application.

This commit also moves argument handling from a separate thread to
GtkApplication.do_startup().
@deltragon
Copy link
Collaborator Author

deltragon commented Jan 2, 2024 •
edited
Loading

Note that there are multiple uses of deprecated apis in the trayicon plugin.
However, I propose to completely replace that in #558, as libappindicator is not compatible with gtk4 anyways.

@deltragon deltragon mentioned this pull request Jan 2, 2024
Draft
@deltragon
Copy link
Collaborator Author

Added a commit to fix deprecations in the delete/reset buttons in the settings dialog.

@deltragon
Copy link
Collaborator Author

Would someone be open to reviewing this? I have tested this extensively on my machine, but would prefer having a second set of eyes look over the PR before merging.

@deltragon deltragon requested a review from AdamPS June 26, 2024 14:19
@archisman-panigrahi
Copy link
Collaborator

I can review it. I use plasma 5 (Kubuntu), plasma 6 (arch) and cinnamon (mint).

Where would you like me to review it, and what feature should I review?

@deltragon
Copy link
Collaborator Author

I think just the basic features (making sure it starts correctly, the break starts correctly) should be enough.

@deltragon
Copy link
Collaborator Author

Oh, and a review on Cinnamon would be good - I've already tested Plasma 5/6.

archisman-panigrahi
archisman-panigrahi approved these changes Jun 29, 2024
View reviewed changes
Copy link
Collaborator

@archisman-panigrahi archisman-panigrahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on Cinnamon, and could not find any regressions. I propose merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archisman-panigrahi archisman-panigrahi archisman-panigrahi approved these changes

@nifadyev nifadyev Awaiting requested review from nifadyev

@AdamPS AdamPS Awaiting requested review from AdamPS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deltragon @archisman-panigrahi