smartpause: use X API instead of xprintidle subprocess

debian/control

@@ -9,7 +9,7 @@ Homepage: https://github.com/slgobinath/SafeEyes/
 
 Package: safeeyes
 Architecture: all
-Depends: ${misc:Depends}, ${python3:Depends}, gir1.2-appindicator3-0.1, python3 (>= 3.4.0), python3-xlib, python3-dbus, gir1.2-notify-0.7, python3-babel, x11-utils, xprintidle, alsa-utils, python3-psutil
+Depends: ${misc:Depends}, ${python3:Depends}, gir1.2-appindicator3-0.1, python3 (>= 3.4.0), python3-xlib, python3-dbus, gir1.2-notify-0.7, python3-babel, x11-utils, python3-xcffib, alsa-utils, python3-psutil
 Description: Safe Eyes
  Safe Eyes is a simple tool to remind you to take periodic breaks for your eyes. This is essential for anyone spending more time on the computer to avoid eye strain and other physical problems.
  .

safeeyes/plugins/smartpause/dependency_checker.py

@@ -20,12 +20,9 @@
 
 
 def validate(plugin_config):
-    command = None
     if Utility.DESKTOP_ENVIRONMENT == "gnome" and Utility.IS_WAYLAND:
         command = "dbus-send"
-    else:
-        command = "xprintidle"
-    if not Utility.command_exist(command):
-        return _("Please install the command-line tool '%s'") % command
-    else:
-        return None
+        if not Utility.command_exist(command):
+            return _("Please install the command-line tool '%s'") % command
+
+    return None

safeeyes/plugins/smartpause/plugin.py

@@ -22,6 +22,11 @@
 import threading
 import re
 import os
+from typing import Optional
+
+import xcffib
+import xcffib.xproto
+import xcffib.screensaver
 
 from safeeyes import Utility
 from safeeyes.model import State
@@ -45,6 +50,7 @@
 waiting_time = 2
 interpret_idle_as_break = False
 is_wayland_and_gnome = False
+xcb_connection: Optional[xcffib.Connection] = None
 
 
 def __gnome_wayland_idle_time():
@@ -68,16 +74,29 @@ def __gnome_wayland_idle_time():
         return 0
 
 
+def __x11_idle_time():
+    assert xcb_connection is not None
+    try:
+        ext = xcb_connection(xcffib.screensaver.key)
+        root_window = xcb_connection.get_setup().roots[0].root
+        query = ext.QueryInfo(root_window)
+        info = query.reply()
+        # Convert to seconds
+        return info.ms_since_user_input / 1000
+    except Exception:
+        logging.warning("Failed to get system idle time from XScreenSaver API", exc_info=True)
+        return 0
+
+
 def __system_idle_time():
     """
-    Get system idle time in minutes.
-    Return the idle time if xprintidle is available, otherwise return 0.
+    Get system idle time in seconds.
     """
     try:
         if is_wayland_and_gnome:
             return __gnome_wayland_idle_time()
-        # Convert to seconds
-        return int(subprocess.check_output(['xprintidle']).decode('utf-8')) / 1000
+        else:
+            return __x11_idle_time()
     except BaseException:
         return 0
 
@@ -115,6 +134,7 @@ def init(ctx, safeeyes_config, plugin_config):
     global interpret_idle_as_break
     global postpone_if_active
     global is_wayland_and_gnome
+    global xcb_connection
     logging.debug('Initialize Smart Pause plugin')
     context = ctx
     enable_safe_eyes = context['api']['enable_safeeyes']
@@ -171,7 +191,8 @@ def on_start():
     """
     Start a thread to continuously call xprintidle.
     """
-    global active
+    global xcb_connection
+    xcb_connection = xcffib.connect()
     if not __is_active():
         # If SmartPause is already started, do not start it again
         logging.debug('Start Smart Pause plugin')
@@ -185,6 +206,10 @@ def on_stop():
     """
     global active
     global smart_pause_activated
+    global xcb_connection
+    if xcb_connection is not None:
+        xcb_connection.disconnect()
+        xcb_connection = None
     if smart_pause_activated:
         # Safe Eyes is stopped due to system idle
         smart_pause_activated = False

setup.py

@@ -7,7 +7,8 @@
     'babel',
     'psutil',
     'PyGObject',
-    'python-xlib'
+    'python-xlib',
+    'xcffib'
 ]
 
 _ROOT = os.path.abspath(os.path.dirname(__file__))