Skip to content

Commit

Permalink
cleanup quadiron.h
Browse files Browse the repository at this point in the history
`quadiron.h` is the public header, as such it should only
contains/expose the public interface of the library (and not everything,
as that was the case).

Refs: scality#160
  • Loading branch information
slaperche-scality committed Aug 3, 2018
1 parent 6f2c65f commit c87274a
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 41 deletions.
9 changes: 0 additions & 9 deletions src/core.h
Original file line number Diff line number Diff line change
Expand Up @@ -96,15 +96,6 @@ struct GroupedValues {
uint32_t flag;
};

/** Return the version string of QuadIron.
*
* The version string has the form MAJOR.MINOR.PATCH-REVISION, where '-REVISION'
* is optional (only present for development version).
*
* @return the version string.
*/
const char* get_version();

/** Return a reference to the global PRNG. */
static inline std::mt19937& prng()
{
Expand Down
1 change: 1 addition & 0 deletions src/gf_ext.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@

#include "arith.h"
#include "gf_base.h"
#include "polynomial.h"

namespace quadiron {

Expand Down
39 changes: 9 additions & 30 deletions src/quadiron.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,42 +36,21 @@
* The root namespace of the QuadIron library.
*/

#include "arith.h"
#include "core.h"
#include "fec_base.h"
#include "fec_rs_fnt.h"
#include "fec_rs_gf2n.h"
#include "fec_rs_gf2n_fft.h"
#include "fec_rs_gf2n_fft_add.h"
#include "fec_rs_gfp_fft.h"
#include "fec_rs_nf4.h"
#include "fft_2.h"
#include "fft_2n.h"
#include "fft_add.h"
#include "fft_base.h"
#include "fft_ct.h"
#include "fft_gt.h"
#include "fft_large.h"
#include "fft_naive.h"
#include "fft_single.h"
#include "gf_base.h"
#include "gf_bin_ext.h"
#include "gf_ext.h"
#include "gf_nf4.h"
#include "gf_prime.h"
#include "gf_ring.h"
#include "misc.h"
#include "polynomial.h"
#include "property.h"
#include "vec_buf_doubled.h"
#include "vec_buf_zero_ext.h"
#include "vec_buffers.h"
#include "vec_doubled.h"
#include "vec_matrix.h"
#include "vec_poly.h"
#include "vec_slice.h"
#include "vec_vector.h"
#include "vec_view.h"
#include "vec_zero_ext.h"

/** Return the version string of QuadIron.
*
* The version string has the form MAJOR.MINOR.PATCH-REVISION, where '-REVISION'
* is optional (only present for development version).
*
* @return the version string.
*/
const char* get_version();

#endif
10 changes: 9 additions & 1 deletion test/fft_utest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,15 @@
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE.
*/
#include "quadiron.h"
#include "fft_2n.h"
#include "fft_add.h"
#include "fft_ct.h"
#include "fft_gt.h"
#include "fft_naive.h"
#include "fft_single.h"
#include "gf_bin_ext.h"
#include "gf_prime.h"
#include "vec_buf_zero_ext.h"

template <typename T>
class FFTUtest {
Expand Down
5 changes: 4 additions & 1 deletion test/gf_utest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE.
*/
#include "quadiron.h"

#include "gf_bin_ext.h"
#include "gf_ext.h"
#include "gf_nf4.h"

template <typename T>
class GFUtest {
Expand Down

0 comments on commit c87274a

Please sign in to comment.