Small updates on the path to .NET 6 #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Totally fine. Thanks for contributing! I'll take a look at this over the weekend. |
|
Why scrub the data.sql? Yeah this is normally scrubbed on engagements, but it serves as a POC. |
|
@phermens-slalom This PR good to review again or are you still making updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled down the feature branch (we might start using this on a client in the coming weeks) and found a few small things that I wanted to tidy up & contribute back.
Hope this is OK and can fit in smoothly upstream?
Might add more as the spikes continue, but happy to propose these changes for now.