Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: API call refactor #9

Open
wants to merge 19 commits into
base: spencer/add-edit-and-delete-functionality
Choose a base branch
from

Conversation

slalexander92
Copy link
Owner

Changes

  • abstract fetch functionality into a request-handler service
  • create orders.service to group order api calls
  • set up reducer/actions/types for orders
  • remove tempReducer file

Purpose

  • DRY up API calls

Approach

  • by leveraging a service-oriented system, we can remove a lot of the pain points of making api calls directly (typos, bug-hunting, etc.)

Pre-Testing TODOs

N/A

Testing Steps

  • login
  • ensure that CRUD operations are still possible in the app.

Learning

Closes Shift3#9

@slalexander92 slalexander92 changed the title Spencer/refactor api calls FEAT: API call refactor Apr 6, 2023
makeRequest,
};


Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RECOMMENDATION: remove rogue space

Suggested change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant