Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack-vitess-r14.0.5-dsdefense: add Uptime metric (#12712) #96

Closed
wants to merge 1 commit into from
Closed

slack-vitess-r14.0.5-dsdefense: add Uptime metric (#12712) #96

wants to merge 1 commit into from

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented Jun 28, 2023 •
edited
Loading

Description

  • Add Uptime metric to vtgate+vttablet

Related Issue(s)

vitessio#12712

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@timvaillancourt
Add Uptime metric (vitessio#12712)
40a39f5 
* Add `Uptime` metric to `vtgate`+`vttablet`

Signed-off-by: Tim Vaillancourt <[email protected]>

* move to go/vt/servenv/status.go

Signed-off-by: Tim Vaillancourt <[email protected]>

* Use nanoseconds for uptime

Signed-off-by: Tim Vaillancourt <[email protected]>

* Move Uptime metrics to servenv.go, remove dupe start time.Time

Signed-off-by: Tim Vaillancourt <[email protected]>

* Use serverStart time.Time

Signed-off-by: Tim Vaillancourt <[email protected]>

---------

Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt timvaillancourt requested a review from a team as a code owner June 28, 2023 17:04
ejortegau
ejortegau reviewed Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@ejortegau ejortegau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How relevant is this for DS defense? LGTM, but I am not sure why we need to back port it for this project. PLenty of tests failed, I set the to run again.

@github-actions
Copy link

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale label Jul 30, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

This PR was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this Aug 7, 2023
@timvaillancourt timvaillancourt deleted the pr-12712-slack-vitess-r14.0.5-dsdefense branch August 15, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejortegau ejortegau ejortegau left review comments

Assignees
No one assigned
Labels
Stale upstream-backport An upstream backport v14-dsdefense
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timvaillancourt @ejortegau