Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase health check channel buffer (#17821) #624

Open
wants to merge 2 commits into
base: slack-15.0
Choose a base branch
from
Open

Increase health check channel buffer (#17821) #624

wants to merge 2 commits into from

Conversation

makinje16
Copy link
Member

Description

This PR backports #17821 as it solves an issue in which vtgate buffering would time out after receiving a healthcheck from a new primary.

Related Issue(s)

issue

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@makinje16 makinje16 requested review from sbaker617 and tanjinx March 12, 2025 19:02
@makinje16 makinje16 requested a review from a team as a code owner March 12, 2025 19:02
@salesforce-cla Salesforce CLA
Copy link

Thanks for the contribution! Before we can merge this, we need @GuptaManan100 to sign the Salesforce Inc. Contributor License Agreement.

@github-actions github-actions bot added this to the v15.0.5 milestone Mar 12, 2025
@timvaillancourt
Copy link
Member

@makinje16 can we also make a backport to slack-21.0? There should be no conflicts 🤞 🙇

@makinje16
go mod tidy
677d41f 
Signed-off-by: Malcolm Akinje <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbaker617 sbaker617 Awaiting requested review from sbaker617

@tanjinx tanjinx Awaiting requested review from tanjinx

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla:missing upstream-backport An upstream backport v21 v22-backport
Projects
None yet
Milestone
v15.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@makinje16 @timvaillancourt @GuptaManan100