Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack 21.0: backport v22 VTOrc improvements, part 2 #622

Open
wants to merge 6 commits into
base: slack-21.0
Choose a base branch
from
Open

slack 21.0: backport v22 VTOrc improvements, part 2 #622

wants to merge 6 commits into from

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented Mar 12, 2025 •
edited
Loading

Description

This PR backports more v22 VTOrc fixes we run on slack-19.0:

  1. vtorc: remove duplicate instance read from backend vitessio/vitess#17834
  2. vtorc: add index for inst.ReadInstanceClusterAttributes table scan vitessio/vitess#17866
  3. Add stats for shards watched by VTOrc, purge stale shards vitessio/vitess#17815
  4. Remove unused code in discovery queue creation vitessio/vitess#17515
  5. vtorc: cleanup discover queue, add concurrency flag vitessio/vitess#17825

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@salesforce-cla Salesforce CLA
Copy link

Thanks for the contribution! Before we can merge this, we need @GuptaManan100 to sign the Salesforce Inc. Contributor License Agreement.

@github-actions github-actions bot added this to the v21.0.3 milestone Mar 12, 2025
@timvaillancourt
make compat with v21
c80c2cf 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt timvaillancourt marked this pull request as ready for review March 12, 2025 14:22
@timvaillancourt timvaillancourt requested a review from a team as a code owner March 12, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:missing Component: VTOrc upstream-backport An upstream backport v21 v22-backport
Projects
None yet
Milestone
v21.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@timvaillancourt @GuptaManan100