Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VStream API: allow keyspace-level heartbeats to be streamed (#16593) #620

Open
wants to merge 4 commits into
base: slack-19.0
Choose a base branch
from
Open

VStream API: allow keyspace-level heartbeats to be streamed (#16593) #620

wants to merge 4 commits into from

Conversation

makinje16
Copy link
Member

@makinje16 makinje16 commented Mar 7, 2025 •
edited by tanjinx
Loading

Description

backport vitessio#16593

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@salesforce-cla Salesforce CLA
Copy link

salesforce-cla bot commented Mar 7, 2025

Thanks for the contribution! Before we can merge this, we need @rohit-nayak-ps to sign the Salesforce Inc. Contributor License Agreement.

@github-actions github-actions bot added this to the v19.0.7 milestone Mar 7, 2025
@tanjinx tanjinx marked this pull request as ready for review March 10, 2025 16:42
@tanjinx tanjinx requested a review from a team as a code owner March 10, 2025 16:42
@tanjinx tanjinx mentioned this pull request Mar 10, 2025
Closed
5 tasks
@tanjinx tanjinx mentioned this pull request Mar 12, 2025
Closed
4 tasks
tanjinx
tanjinx reviewed Mar 12, 2025
View reviewed changes
go/vt/vtgate/vstream_manager.go Outdated
}
log.Infof("Starting to vstream from %s, with req %+v", tabletAliasString, req)
var vstreamCreatedOnce sync.Once
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 621 should be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanjinx tanjinx tanjinx left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla:missing
Projects
None yet
Milestone
v19.0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@makinje16 @tanjinx @rohit-nayak-ps