Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack-19.0: fix broken github action workflows #556

Merged
merged 2 commits into from
Nov 8, 2024
Merged

slack-19.0: fix broken github action workflows #556

merged 2 commits into from
Nov 8, 2024

Conversation

timvaillancourt
Copy link
Member

Description

This PR fixes 2 x upgrade/downgrade query serving tests that were silently broken/disabled by a bad merge conflict fix in #551

Related Issue(s)

#551

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@timvaillancourt timvaillancourt added bug Something isn't working v19 labels Nov 7, 2024
@timvaillancourt timvaillancourt requested a review from a team as a code owner November 7, 2024 23:08
@github-actions github-actions bot added this to the v19.0.7 milestone Nov 7, 2024
@timvaillancourt timvaillancourt merged commit bc5e02d into slack-19.0 Nov 8, 2024
161 of 163 checks passed
@timvaillancourt timvaillancourt deleted the fix-upgrade-downgrade-queries-test branch November 8, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanjinx tanjinx tanjinx approved these changes

Assignees
No one assigned
Labels
bug Something isn't working v19
Projects
None yet
Milestone
v19.0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@timvaillancourt @tanjinx