Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forward-fit: Allow setting grpc send and recv message sizes independently (#481) #540

Merged
merged 4 commits into from
Oct 24, 2024
Merged

forward-fit: Allow setting grpc send and recv message sizes independently (#481) #540

merged 4 commits into from
Oct 24, 2024

Conversation

tanjinx
Copy link

@tanjinx tanjinx commented Oct 24, 2024

forward-fit #481

Description

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@henryr @pbibra @tanjinx
Allow setting grpc send and recv message sizes independently (#481)
5e81df3 
* Allow setting grpc send and recv message sizes independently

Signed-off-by: Henry Robinson <[email protected]>

* Add comments

Signed-off-by: Henry Robinson <[email protected]>

* Update .txt files

Signed-off-by: Henry Robinson <[email protected]>

* update help txt ordering

Signed-off-by: Priya Bibra <[email protected]>

---------

Signed-off-by: Henry Robinson <[email protected]>
Signed-off-by: Priya Bibra <[email protected]>
Co-authored-by: Priya Bibra <[email protected]>
@tanjinx tanjinx requested a review from a team as a code owner October 24, 2024 04:07
@github-actions github-actions bot added this to the v19.0.5 milestone Oct 24, 2024
@tanjinx tanjinx merged commit f177f55 into slack-19.0 Oct 24, 2024
161 of 163 checks passed
@tanjinx tanjinx deleted the forwardfit-grpc-recv-size branch October 24, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvaillancourt timvaillancourt timvaillancourt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v19.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@tanjinx @timvaillancourt @henryr