Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack-15.0: pre-backport ChangeTabletTags RPC for testing #524

Closed
wants to merge 10 commits into from
Closed

slack-15.0: pre-backport ChangeTabletTags RPC for testing #524

wants to merge 10 commits into from

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented Sep 30, 2024 •
edited
Loading

Description

This PR backports 2 x upstream PRs (one is unmerged) that allow tablet tags to be dynamic

This will allow this feature to be tested ahead of PR submission

Related Issue(s)

  1. Add tablet-tags/--init_tags stats vitessio/vitess#16695
  2. Add ChangeTabletTags RPC to vtctl, ChangeTags RPC to vttablet vitessio/vitess#16857

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@github-actions github-actions bot added this to the v15.0.5 milestone Sep 30, 2024
@timvaillancourt
v15 tweaks
c7c33ac 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt
another v15 tweak
2ba8896 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt timvaillancourt marked this pull request as ready for review September 30, 2024 17:56
@timvaillancourt timvaillancourt requested a review from a team as a code owner September 30, 2024 17:56
@timvaillancourt
add publishForDisplay call
f13d5ef 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt
Copy link
Member Author

Testing on our infra went well ✅, output here: vitessio#16857 (comment)

@timvaillancourt
Add ChangeTabletTags/ChangeTags RPCs
ea2d444 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt
fix test
d827600 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt
Copy link
Member Author

Rebased from vitessio#16857

@timvaillancourt timvaillancourt deleted the ChangeTabletTagsRPC-slack-15.0 branch October 10, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
upstream-backport An upstream backport v15 v21-backport
Projects
None yet
Milestone
v15.0.5
Development

Successfully merging this pull request may close these issues.
1 participant
@timvaillancourt