Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack-19.0: backport v20 PRs, set slack-15.0 as previous release #386

Draft
wants to merge 17 commits into
base: slack-19.0
Choose a base branch
from

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented May 30, 2024

Description

This PR contains the typical hacks for a Slack release such as:

  1. CI runner updates to slackhq self-hosted
  2. Delete skip logic in tests (always run full CI)
  3. Private repo git-config for https://github.com/slackhq/vitess-addons
  4. CODEOWNERS setup for @slackhq/vitess-approvers
  5. Previous release set to https://github.com/slackhq/vitess/tree/slack-15.0

Also all v20 backports we require we cherry picked

Backports

  1. Load --grpc_auth_static_client_creds file once vitessio/vitess#15030
  2. Limit concurrent creation of healthcheck gRPC connections vitessio/vitess#15053
  3. Filter by keyspace earlier in tabletgateways WaitForTablets(...) vitessio/vitess#15347
  4. Make Durabler interface methods public vitessio/vitess#15548

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@github-actions github-actions bot added this to the v19.0.4 milestone May 30, 2024
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
@slackhq slackhq deleted a comment from codecov-commenter May 31, 2024
@slackhq slackhq deleted a comment from codecov-commenter May 31, 2024
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Signed-off-by: Tim Vaillancourt <[email protected]>
Copy link

github-actions bot commented Jul 1, 2024

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants