Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed field list background color in dark mode #39

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

kyle-sammons
Copy link
Collaborator

@kyle-sammons kyle-sammons commented Nov 9, 2023

Summary

Previous to this we were hardcoding in the background color irrespective of whether the user was using dark mode or not. This PR fixes that and sets a reasonable color depending on what mode the user is using.

Resolves #35

Screenshots

Before light

image

Before dark

image

After light

image

After dark

image

Requirements (place an x in each [ ])

The following point can be removed after setting up CI (such as Travis) with coverage reports (such as Codecov)

  • I've written tests to cover the new code and functionality included in this PR.

The following point can be removed after setting up a CLA reporting tool such as cla-assistant.io

Copy link

github-actions bot commented Nov 9, 2023

OpenAI failed to generate a review:

You tried to access openai.ChatCompletion, but this is no longer supported in openai>=1.0.0 - see the README at https://github.com/openai/openai-python for the API.

You can run openai migrate to automatically upgrade your codebase to use the 1.0.0 interface.

Alternatively, you can pin your installation to the old version, e.g. pip install openai==0.28

A detailed migration guide is available here: openai/openai-python#742

@kyle-sammons kyle-sammons merged commit 4c1a1c7 into master Nov 9, 2023
3 checks passed
@kyle-sammons kyle-sammons deleted the ksammons-MON-5956-Dark-Mode-Inconsistency branch November 9, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode inconsistency
2 participants