Fix linting to comply with hhast splinter rules #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @junoatwork. @jscheinblum is on PTO this week so tagging you in this. After merging a change to support hack_namespace proto option, I cut a new release of proto-hack i.e. v8.5.0 this morning. When bumping up the proto-hack version in webapp, I got this linter test failure. Making this change to satisfy the splinter in webapp. Once this is merged, I will modify the release 8.5.0 to include this change(or I can make a new release). After that, I should be able to bump up proto-hack version in webapp. |
|
Linking to previous PR, #31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified
lib/grpc.phpto comply with splinter rules in webapp. This change is no-op otherwise. Tested by building a new binary, running existing tests to ensure this change is safe.