Implement support for proto3 optional #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proto3 optional requires opting into the experimental feature in our code generator. proto3 optional is implemented as a one-off synthetic field so we must treat those as normal objects in our codegenerator. You can find the instructions on how to handle those in the upstream protobuf documentation: https://github.com/protocolbuffers/protobuf/blob/main/docs/implementing_proto3_presence.md The PR adds tests for the logic for both binary and JSON decoding. We are missing reflection support but that seemed reasonable for now.
junoatwork
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Implementation seems good and straightforward. I'm not 100% familiar with all of the cases which should be covered, so this shouldn't be taken as a correctness audit, but from what I can tell this implementation seems consistent with the proto3 optional documentation linked in the PR description, and the test cases seem reasonable. See comments inline.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proto3 optional requires opting into the
experimental feature in our code generator.
proto3 optional is implemented as a one-off
synthetic field so we must treat those as normal
objects in our codegenerator. You can find the
instructions on how to handle those in the upstream protobuf documentation:
https://github.com/protocolbuffers/protobuf/blob/main/docs/implementing_proto3_presence.md
The PR adds tests for the logic for both binary
and JSON decoding. We are missing reflection
support but that seemed reasonable for now.