upgrade to yaml.v3 #1148
Open
upgrade to yaml.v3 #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main nice fix here is that maps unmarshal into `map[string]any` instead of `map[any]any`, so it cleans things up a bit.
Since yaml.v3 doesn't automatically convert yes to bool now, for backwards compat
nbrownus
reviewed
Mar 12, 2025
| case bool: | ||
| return x, true | ||
| case string: | ||
| switch x { |
There was a problem hiding this comment.
probably not, let me see what yaml.v2 did for this
There was a problem hiding this comment.
ah this is what they are doing in v3 if you unmarshal into a Bool:
So we can probably copy that.
This is what v2 did:
There was a problem hiding this comment.
although if you look above this file at the existing config.GetBool it only allowed the lowercase versions. So we might want to match that for backwards compat. This new config.AsBool is only used for allow_list entries.
There was a problem hiding this comment.
Existing in v1.9.5: https://github.com/slackhq/nebula/blob/v1.9.5/config/config.go#L257-L262
nbrownus
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main nice fix here is that maps unmarshal into
map[string]anyinstead of
map[any]any, so it cleans things up a bit.The only gotcha I see for our uses is that the Yaml 1.1 bool types like
yeswon't automatically be set as a bool inside ofmap[string]any. So I added a little helperconfig.AsBoolto keep backwards compat there.