-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream processed exec implementation #20
Conversation
when (val retrySignal = resultProcessor.process(logFile, false)) { | ||
is RetrySignal.Ack, | ||
RetrySignal.Unknown -> { | ||
echo("Processor exited with 0, exiting with original exit code...") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This output is wrong, if it exited with 0 we wouldn't be here. We also exit this process with 0 always (line 111), do we want to reflect the actual result of the command or do we always want to succeed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch e8c3d17
break | ||
} | ||
is RetrySignal.RetryDelayed -> { | ||
echo("Processor script exited with 2, rerunning the command after 1 minute...") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 minute may not be correct, since we pull the delay from the retry signal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
branch.startsWith("mq-") || branch.startsWith("gh-readonly-queue") -> "merge-queue" | ||
else -> "pull-request" | ||
} | ||
setReleaseStage(releaseStage) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice
This introduces a new
ProcessedExecCli
program that can be used to execute commands with a layer of added tracing. This CLI does the followingUsage
Use this in a local CI kts script and then pass it args
processed-exec.main.kts
Future work