Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct ComposeCompositionLocalUsage allow-list retrieval #368

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seve-andre
Copy link

Since v1.3.1, ComposeCompositionLocalUsageDetector couldn't fetch the allowed-composition-locals list correctly, as mentioned in issue #267.

After carefully reading the Android Lint API Guide, I found this.

If your lint check still needs to work with older versions of lint, you can bypass the option registration, and just read option values directly from the configuration.

The correct way to read the value of the Option, is the following.

 val option: String? = configuration.getOption(ISSUE, OPTION_NAME)

Copy link

salesforce-cla bot commented Jul 1, 2024

Thanks for the contribution! Before we can merge this, we need @seve-andre to sign the Salesforce Inc. Contributor License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant