-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Shared elements experimenting #1330
base: main
Are you sure you want to change the base?
Conversation
.sharedBounds( | ||
sharedContentState = rememberSharedContentState(key = "animal-${state.id}"), | ||
animatedVisibilityScope = sharedElementAnimatedContentScope(), | ||
) | ||
.sharedElement( | ||
state = rememberSharedContentState(key = "animal-image-${state.id}"), | ||
animatedVisibilityScope = sharedElementAnimatedContentScope(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a particular reason why you are adding both sharedBounds and sharedElement on this item?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope! Was moving them around and alternating between the two.
- Interceptor to set the animation - Interceptor to setup shared elements - Add a new `thenIfSharedTransitionScope` modifier to use shared element api's
Playing with the new shared elements api over in the star sample to avoid some KMP stuff.
Right now this has two locals for the current scopes, need to clean that up a bit 馃槄
Q's
Demo
shared.mp4