Update agp to v8.5.0 (#1480)

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.android.test](https://developer.android.com/studio/build) ([source](https://android.googlesource.com/platform/tools/base)) | plugin | minor | `8.4.2` -> `8.5.0` | | [com.android.library](https://developer.android.com/studio/build) ([source](https://android.googlesource.com/platform/tools/base)) | plugin | minor | `8.4.2` -> `8.5.0` | | [com.android.application](https://developer.android.com/studio/build) ([source](https://android.googlesource.com/platform/tools/base)) | plugin | minor | `8.4.2` -> `8.5.0` | | [com.android.tools.build:gradle](http://tools.android.com/) ([source](https://android.googlesource.com/platform/tools/base)) | dependencies | minor | `8.4.2` -> `8.5.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  --------- Co-authored-by: Zac Sweers <[email protected]>
slackhq · Jun 25, 2024 · 76b2262 · 76b2262
1 parent b9f8fa5
commit 76b2262
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 6 deletions.
diff --git a/gradle.properties b/gradle.properties
@@ -19,7 +19,7 @@ org.gradle.jvmargs=-Xms1g -Xmx4g -Dfile.encoding=UTF-8 -XX:MaxMetaspaceSize=1g -
 android.useAndroidX=true
 
 ## Force use of the latest android lint version
-android.experimental.lint.version=8.5.0-alpha07
+android.experimental.lint.version=8.6.0-alpha07
 
 # Helps make baseline profile generation more reliable
 # https://issuetracker.google.com/issues/287312019

diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -5,7 +5,7 @@ androidx-annotation = "1.8.0"
 androidx-appcompat = "1.7.0"
 androidx-browser = "1.8.0"
 androidx-lifecycle = "2.8.2"
-agp = "8.4.2"
+agp = "8.5.0"
 anvil = "2.5.0-beta09"
 atomicfu = "0.24.0"
 benchmark = "1.2.4"

diff --git a/samples/star/build.gradle.kts b/samples/star/build.gradle.kts
@@ -78,14 +78,14 @@ kotlin {
         implementation(libs.compose.ui.tooling.preview)
         implementation(libs.compose.uiUtil)
         implementation(libs.coroutines)
-        implementation(libs.kotlinx.datetime)
         implementation(libs.kotlinx.immutable)
         implementation(libs.kotlinx.serialization.json.okio)
         implementation(libs.ktor.client)
         implementation(libs.ktor.client.contentNegotiation)
         implementation(libs.ktor.client.auth)
         implementation(libs.ktor.serialization.json)
         implementation(libs.okio)
+        implementation(libs.kotlinx.datetime)
         implementation(libs.sqldelight.coroutines)
         implementation(libs.sqldelight.primitiveAdapters)
         implementation(libs.windowSizeClass)
@@ -136,14 +136,13 @@ kotlin {
       androidMain {
         dependencies {
           implementation(libs.androidx.appCompat)
+          implementation(libs.androidx.compose.integration.activity)
           implementation(libs.androidx.browser)
           implementation(libs.androidx.compose.accompanist.flowlayout)
           implementation(libs.androidx.compose.accompanist.pager)
           implementation(libs.androidx.compose.accompanist.pager.indicators)
           implementation(libs.androidx.compose.accompanist.systemUi)
           implementation(libs.androidx.compose.googleFonts)
-          implementation(libs.androidx.compose.integration.activity)
-          implementation(libs.androidx.compose.integration.activity)
           implementation(libs.androidx.compose.ui.tooling)
           implementation(libs.coroutines.android)
           implementation(libs.sqldelight.driver.android)
@@ -186,9 +185,9 @@ kotlin {
       jvmMain {
         dependencies {
           implementation(compose.desktop.currentOs)
+          implementation(libs.appDirs)
           implementation(libs.coroutines.swing)
           implementation(libs.sqldelight.driver.jdbc)
-          implementation(libs.appDirs)
         }
       }
     }

diff --git a/samples/tacos/src/main/kotlin/com/slack/circuit/tacos/step/FillingsOrderStep.kt b/samples/tacos/src/main/kotlin/com/slack/circuit/tacos/step/FillingsOrderStep.kt
@@ -49,6 +49,8 @@ internal class FillingsProducerImpl(private val repository: IngredientsRepositor
     orderDetails: OrderDetails,
     eventSink: (OrderStep.Event) -> Unit,
   ): FillingsOrderStep.State {
+    // False positive - https://issuetracker.google.com/issues/349411310
+    @Suppress("ProduceStateDoesNotAssignValue")
     val ingredients by
       produceState<ImmutableList<Ingredient>?>(null) { value = repository.getFillings() }
 

diff --git a/samples/tacos/src/main/kotlin/com/slack/circuit/tacos/step/OrderStep.kt b/samples/tacos/src/main/kotlin/com/slack/circuit/tacos/step/OrderStep.kt
@@ -4,6 +4,7 @@ package com.slack.circuit.tacos.step
 
 import androidx.annotation.StringRes
 import androidx.compose.runtime.Composable
+import androidx.compose.runtime.Stable
 import com.slack.circuit.tacos.OrderDetails
 import com.slack.circuit.tacos.model.Ingredient
 
@@ -46,6 +47,7 @@ sealed interface OrderStep {
   data object Restart : Event
 
   /** The primary [Composable] entry point to produce order step state */
+  @Stable
   fun interface StateProducer<T : State> {
     /**
      * Implementing classes should consume [OrderDetails] and emit state extending

diff --git a/samples/tacos/src/main/kotlin/com/slack/circuit/tacos/step/ToppingsOrderStep.kt b/samples/tacos/src/main/kotlin/com/slack/circuit/tacos/step/ToppingsOrderStep.kt
@@ -60,6 +60,8 @@ internal class ToppingsProducerImpl(private val repository: IngredientsRepositor
     minimumToppings: Int,
     eventSink: (OrderStep.Event) -> Unit,
   ): ToppingsOrderStep.State {
+    // False positive - https://issuetracker.google.com/issues/349411310
+    @Suppress("ProduceStateDoesNotAssignValue")
     val ingredients by
       produceState<ImmutableList<Ingredient>?>(null) { value = repository.getToppings() }
 

diff --git a/samples/tutorial/src/androidMain/kotlin/com/slack/circuit/tutorial/impl/InboxScreen.kt b/samples/tutorial/src/androidMain/kotlin/com/slack/circuit/tutorial/impl/InboxScreen.kt
@@ -38,6 +38,8 @@ class InboxPresenter(
 ) : Presenter<InboxScreen.State> {
   @Composable
   override fun present(): InboxScreen.State {
+    // False positive - https://issuetracker.google.com/issues/349411310
+    @Suppress("ProduceStateDoesNotAssignValue")
     val emails by
       produceState<List<Email>>(initialValue = emptyList()) { value = emailRepository.getEmails() }
     return InboxScreen.State(emails) { event ->