Improve ES query compatibility for Grafana 10 #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanlb
commented
Mar 21, 2024
kaldb/src/main/java/com/slack/kaldb/elasticsearchApi/ElasticsearchApiService.java
Show resolved
Hide resolved
bryanlb
changed the title
bryanlb
force-pushed
the
bburkholder/es-query
branch
from
0672c70
to
ad33828
Compare
bryanlb
force-pushed
the
bburkholder/es-query
branch
3 times, most recently
from
64b54f2
to
a1c99b9
Compare
bryanlb
force-pushed
the
bburkholder/es-query
branch
from
a1c99b9
to
79a4f8e
Compare
vthacker
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves ES query support for Grafana 10. This is to enable easier datasource migrations from ES to Astra.
This improves the current state of #798, but a greater rework of query parsing is still needed.