Add optional S3 streaming for cache nodes #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
bburkholder/assorted-enhancements
to
master
September 18, 2024 23:56
bryanlb
force-pushed
the
bburkholder/s3-streaming
branch
from
01e1e45
to
9e3b3ef
Compare
bryanlb
force-pushed
the
bburkholder/s3-streaming
branch
3 times, most recently
from
7119e67
to
9d227af
Compare
bryanlb
force-pushed
the
bburkholder/s3-streaming
branch
from
9d227af
to
9596569
Compare
bryanlb
force-pushed
the
bburkholder/s3-streaming
branch
from
9596569
to
21accce
Compare
kyle-sammons
requested changes
Oct 1, 2024
astra/src/main/java/com/slack/astra/blobfs/S3RemoteDirectory.java
Outdated
Show resolved
Hide resolved
kyle-sammons
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an experimental flag for the cache nodes, that optionally streams in the data from object storage. This removes the requirement for disk for cache nodes, enabling switching to significantly cheaper storage types.
Current implementation still results in the assignments still being "downloaded" and "initialized," but transparent to Lucene this is fetching with block-level caches into memory at the time of request.
To use set:
optionally: