This repository was archived by the owner on Nov 3, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 601
Add ability to choose background interaction mode (.dismiss / .forward or .none) #115
Open
ilia3546
wants to merge
4
commits into
slackhq:master
Choose a base branch
from
ilia3546:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ilya Kharlamov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
ste57
approved these changes
Oct 28, 2020
|
I really look forward to have this functionality! |
ziv-mishloha
approved these changes
Nov 4, 2020
a777med
approved these changes
Nov 27, 2020
|
Please, could someone with write access review this PR? I have stopped using this library because of this issue. @jordanpichler @ste57 @TosinAF @Marcocanc |
Contributor
|
Hi guys, Do we have a plan to merge it? |
|
Works really well! 💯 Hope it gets merged soon |
ivopintodasilva
pushed a commit
to amieso/PanModal
that referenced
this pull request
Mar 11, 2021
stinger
approved these changes
Nov 11, 2021
javikr
approved these changes
May 24, 2022
javikr
approved these changes
May 24, 2022
manucodin
approved these changes
Jun 2, 2022
kuuhaku0
approved these changes
Apr 3, 2023
zzisun
approved these changes
Apr 16, 2023
SwiftyJoeyy
approved these changes
May 3, 2023
kuuhaku0
approved these changes
May 6, 2023
|
Still not yet being merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue - #100
Now you can choose one of background interaction modes:
.dismiss- Taps dismiss the modal immediately.forward- Touches are forwarded to the lower window (In most cases it would be the application main window that will handle it.none- Absorbs touches. The modal does nothing (Swallows the touch)Example:
I think now option
allowsTapToDismisscan be marked as deprecated.Requirements (place an
xin each[ ])I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.
I've written tests to cover the new code and functionality included in this PR.