-
Notifications
You must be signed in to change notification settings - Fork 601
Add ability to choose inset and visiablity for scroll view #109
base: master
Are you sure you want to change the base?
Add ability to choose inset and visiablity for scroll view #109
Conversation
|
Andrey Gluhih seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Any update regarding this PR? ❤️ |
|
yeah, I'm sorry, struggling with CLA signing. As I understood I should add commit with my email? |
|
I accidentally came across the same issue and this PR would come in really handy. @Sc4pego4t I'm rooting for you to get this merged 🙏 |
|
@ste57 can you please help me? I've accepted policies, but merging is still blocked |
| /** | ||
| The inset for scroll view which will override default one (bottomLayoutGuide.height) | ||
|
|
||
| Default value is true. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this shouldn't be true. bottomLayoutGuide.length is probably what it should be
| Default value is true. | |
| Default value is bottomLayoutGuide.length. |
|
@AivarasGus @Sc4pego4t @ste57 created same pr with additional properties for tests and with license stuff fixed #121 if it's not possible to sign this one we can merge mine :) |


Summary
Describe the goal of this PR. Mention any related Issue numbers.
Requirements (place an
xin each[ ])[x ] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[ x] I've read and agree to the Code of Conduct.
[x ] I've written tests to cover the new code and functionality included in this PR.