Skip to content

feat: add webapi response changes as of 2026-08-07 - #1629

Open
slackapi[bot] wants to merge 10 commits into
mainfrom
api
Open

feat: add webapi response changes as of 2026-08-07#1629
slackapi[bot] wants to merge 10 commits into
mainfrom
api

Conversation

@slackapi

@slackapi slackapi Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

This PR updates the web API client and model based on the production E2E test results.

Category

  • slack-api-model (Slack API Data Models)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@slackapi slackapi Bot added the project:slack-api-model project:slack-api-model label Aug 7, 2026
@slackapi
slackapi Bot requested a review from a team as a code owner August 7, 2026 01:43
@slackapi slackapi Bot added the semver:patch label Aug 7, 2026
@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.33%. Comparing base (86ff7ca) to head (d46be60).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1629      +/-   ##
============================================
- Coverage     73.34%   73.33%   -0.01%     
  Complexity     4528     4528              
============================================
  Files           478      478              
  Lines         14314    14314              
  Branches       1491     1491              
============================================
- Hits          10498    10497       -1     
- Misses         2924     2926       +2     
+ Partials        892      891       -1     
Flag Coverage Δ
jdk-14 73.33% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

zimeg and others added 6 commits August 7, 2026 14:38
ActionsResponse.Actions: List<String> workObjectRecord
SchemasResponse: WorkObjectRecord class (id, appId, objectId, objectType)
Actions: WorkObjectRecord inner class with enterprise_search_email_attachment_downloaded

Additive, no breaking changes; verified against the live audit API response.

❤️
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
rtmConnect(token) requests full user info, adding a users.info call
between rtm.connect and the websocket. That second HTTPS request may or
may not reuse the pooled proxy tunnel, so the proxy occasionally sees a
third CONNECT and the callCount assertion flakes between 2 and 3. The
test does not use the connected user info, so request it without the
extra call to keep the count deterministic at 2.

❤️
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌻 A comment as changes happen.

Comment on lines +201 to +203
// fullUserInfoRequired=false: skip the extra users.info call so the proxy sees exactly
// two connections (rtm.connect + websocket), otherwise a third tunnel can be opened
try (RTMClient rtm = slack.rtmConnect(rtmBotToken, false)) { // slack-msgs.com

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 note: Added to reduce flakes of scheduled tests! We now hope to focus on new properties with the test runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant