Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs - nested sidebar #1230

Merged
merged 1 commit into from
Dec 19, 2024
Merged

docs - nested sidebar #1230

merged 1 commit into from
Dec 19, 2024

Conversation

lukegalbraithrussell
Copy link
Contributor

Summary

With a slightly smaller font for the sidebar, this gives us some more room to place with spacing. This places all the guides in a uncollapsed "guides" category, to match the deno slack sdk docs format: https://tools.slack.dev/deno-slack-sdk/

It fixes the bolding issues that currently exists because the css was focused on the deno slack sdk docs

This will be important as we look into building out reference docs (as they can all live under a nice "reference" folder)

Testing

You could locally run it! But it works, promise

Category

  • Document pages under /docs

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • [] I've run ./scripts/install_all_and_run_tests.sh after making the changes.

},
],
sidebarBoltPy: [
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm assuming this is from the python repo formatting -- 4 spaces is python standard i believe

Comment on lines +10 to +14
{ type: "html", value: "<hr>" },
{
type: "category",
label: "Guides",
collapsed: false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is all i added

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (0c79bb1) to head (dd3c7b9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1230   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files         222      222           
  Lines        7501     7501           
=======================================
  Hits         6823     6823           
  Misses        678      678           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukegalbraithrussell lukegalbraithrussell merged commit 72415af into main Dec 19, 2024
16 checks passed
@lukegalbraithrussell lukegalbraithrussell deleted the docs-nested-nav branch December 19, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants