chore(deps): bump black from 24.8.0 to 24.10.0 #1194
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1194 +/- ##
=======================================
Coverage 90.93% 90.93%
=======================================
Files 222 222
Lines 7505 7505
=======================================
Hits 6825 6825
Misses 680 680 ☔ View full report in Codecov by Sentry. |
| @@ -1,3 +1,3 @@ | |||
| mypy==1.11.2 | |||
| flake8==6.0.0 | |||
| black==24.8.0 # Until we drop Python 3.6 support, we have to stay with this version | |||
| black==24.10.0 # Until we drop Python 3.6 support, we have to stay with this version | |||
There was a problem hiding this comment.
@WilliamBergamin @seratch Dependabot would like to bump us to [email protected] from 24.8.0. The Release Notes mention dropping Python 3.8 support and the comment above mentions that we still support Python 3.6. So, it sounds like the latest version of black may not run reliably on Python 3.6.
What's your advice on this PR?
There was a problem hiding this comment.
@mwbrooks Thanks for checking this. Upgrading black to a newer version does not bring any benefits and I personally think still we should keep 3.6 support for a while (say, one or two more years). It's indeed EOLed a long time ago! but for Python and Java, providing much longer supports for EOLed versions would be expected in many cases.
There was a problem hiding this comment.
Thanks @seratch! Is there a range syntax that we can use to prevent @dependabot from trying to upgrade it? For example black<=24.8.0?
There was a problem hiding this comment.
Run all the unit tests / build (3.6) (pull_request)
The test execution does not fail (because it does not use black) but let's keep the current black version this time
There was a problem hiding this comment.
Thanks @seratch! Is there a range syntax that we can use to prevent https://github.com/dependabot from trying to upgrade it? For example black<=24.8.0?
Hmm, honestly i am not sure about the way to prevent this. Even if you use a version range, the bot still tries to upgrade to newer range 😅
There was a problem hiding this comment.
Ah, alright. Well, the comment left on the dependency was enough for me to question accepting the upgrade. Hopefully it'll be enough for other reviewers to know that we don't want to upgrade it yet.
dependabot
bot
force-pushed
the
dependabot/pip/black-24.10.0
branch
from
4d5119f to
dbee0f6
Compare
Bumps [black](https://github.com/psf/black) from 24.8.0 to 24.10.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@24.8.0...24.10.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/pip/black-24.10.0
branch
from
dbee0f6 to
4e237c1
Compare
|
@dependabot don't upgrade this dependency from now on |
|
@dependabot ignore this dependency |
|
OK, I won't notify you about black again, unless you re-open this PR. |
Bumps black from 24.8.0 to 24.10.0.
Release notes
Sourced from black's releases.
Changelog
Sourced from black's changelog.
Commits
1b2427aPrepare release 24.10.0 (#4471)a22b1ebAdd mypyc 3.13 wheel build (#4449)b7d0e72Bump AndreMiras/coveralls-python-action from 65c1672f0b8a201702d86c81b79187df...f1a2f92Include --unstable in cache key (#4466)8d9d18cFix skipping Jupyter cells with unknown %% magic (#4462)bbfdba3Fix docs CI: use venv for uv to fix 'failed to create directory' (#4460)8fb2addUse builtin generics (#4458)2a45cecFix crashes with comments in parentheses (#4453)b4d6d86Drop Python 3.8 support (#4452)ac018c1Require newer aiohttp for blackd (#4451)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)