disc: remove the optional typing of client #1143
Merged
+24
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamBergamin
commented
Aug 30, 2024
| @@ -41,7 +41,7 @@ def listener_runner(self) -> "AsyncioListenerRunner": # type: ignore[name-defin | |||
| return self["listener_runner"] | |||
|
|
|||
| @property | |||
| def client(self) -> Optional[AsyncWebClient]: | |||
There was a problem hiding this comment.
Relevant change ⬆️
| @@ -42,7 +42,7 @@ def listener_runner(self) -> "ThreadListenerRunner": # type: ignore[name-define | |||
| return self["listener_runner"] | |||
|
|
|||
| @property | |||
| def client(self) -> Optional[WebClient]: | |||
There was a problem hiding this comment.
Relevant change ⬆️
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1143 +/- ##
=======================================
Coverage 92.02% 92.02%
=======================================
Files 195 195
Lines 6631 6631
=======================================
Hits 6102 6102
Misses 529 529 ☔ View full report in Codecov by Sentry. |
seratch
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR opens the discussion to why the
context.clientproperty isOptionalLooking back to #31 its seems like the original implementation of the client property could return
None, but this implementation has now changed.Original implementation:
Can we now remove this
Optionaltype annotation, I cannot come up with a use case wherecontext.clientcould beNone, let me know if missing context around this 🤔Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.