MAINT: Update _astropy_init to latest version in astropy package-template #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The compatibility workflow is currently failing for the astropy development version with
ImportError: cannot import name 'update_default_config' from 'astropy.config.configuration': https://github.com/skypyproject/skypy/actions/runs/6681172883/job/18155043088#step:6:117update_default_configwas deprected in astropy 5.0 and was recently removed on the main branch in preparation for 6.0: astropy/astropy#15466This PR updates _astropy_init.py to match the latest version in astropy package-template which no longer requires
update_default_config: https://github.com/astropy/package-template/blob/cookiecutter/%7B%7B%20cookiecutter.package_name%20%7D%7D/%7B%7B%20cookiecutter.module_name%20%7D%7D/_%7B%7B%20cookiecutter._parent_project%20%7D%7D_init.pyThis patch has been demonstrated to resolve the issue on with the compatibility workflow here: https://github.com/rrjbca/skypy/actions/runs/6682165049/job/18157042681
Once approved I can also backport to v0.5.x and make a release v0.5.3 which will be necessary for the compatibility workflow "latest" job to pass.
Checklist