Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Overgeneration of galaxies #577

Closed
wants to merge 1 commit into from
Closed

BUG: Overgeneration of galaxies #577

wants to merge 1 commit into from

Conversation

Fox-Davidson
Copy link
Collaborator

@Fox-Davidson Fox-Davidson commented Nov 11, 2022 •
edited
Loading

Description

Added an h_0^3 to the number density calculated for galaxies and their redshifts. This closes #576 .

Checklist

  • Follow the Contributor Guidelines
  • Write unit tests
  • Write documentation strings
  • Assign someone from your working team to review this pull request
  • Assign someone from the infrastructure team to review this pull request

@Fox-Davidson Fox-Davidson self-assigned this Nov 11, 2022
@Fox-Davidson Fox-Davidson requested a review from a team as a code owner November 11, 2022 18:44
@philipp128
Copy link
Contributor

Thanks, @Fox-Davidson could you also adapt the tests in skypy/galaxies/tests/test_redshift.py. Currently these tests are failing.

@Fox-Davidson
Copy link
Collaborator Author

Closed as failed. Will try again fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itrharrison itrharrison Awaiting requested review from itrharrison

@philipp128 philipp128 Awaiting requested review from philipp128

Assignees

@Fox-Davidson Fox-Davidson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Overgeneration of galaxies
2 participants
@Fox-Davidson @philipp128