Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Delete classy function #560

Merged
merged 4 commits into from
Jul 1, 2022
Merged

MAINT: Delete classy function #560

merged 4 commits into from
Jul 1, 2022

Conversation

Lucia-Fonseca
Copy link
Member

@Lucia-Fonseca Lucia-Fonseca commented Jul 1, 2022 •
edited
Loading

Description

Delete extra classy function, any associated unit tests and references. Merging this PR closes #558 .

Checklist

  • Follow the Contributor Guidelines
  • Write unit tests
  • Write documentation strings
  • Assign someone from your working team to review this pull request
  • Assign someone from the infrastructure team to review this pull request

@Lucia-Fonseca Lucia-Fonseca self-assigned this Jul 1, 2022
@Lucia-Fonseca Lucia-Fonseca marked this pull request as draft July 1, 2022 14:29
@Lucia-Fonseca
Copy link
Member Author

Lucia-Fonseca commented Jul 1, 2022 •
edited
Loading

Still needs to delete the unit test associated

@Lucia-Fonseca Lucia-Fonseca marked this pull request as ready for review July 1, 2022 14:42
@rrjbca rrjbca self-requested a review July 1, 2022 14:47
rrjbca
rrjbca approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@rrjbca rrjbca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rrjbca rrjbca merged commit 9733d25 into skypyproject:module/power_spectrum Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrjbca rrjbca rrjbca approved these changes

@itrharrison itrharrison Awaiting requested review from itrharrison

Assignees

@Lucia-Fonseca Lucia-Fonseca

Labels
module: power spectrum ps-hack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lucia-Fonseca @rrjbca