Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Rename keyword argument noise to shot_noise #479

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

API: Rename keyword argument noise to shot_noise #479

wants to merge 2 commits into from

Conversation

rrjbca
Copy link
Contributor

@rrjbca rrjbca commented Aug 31, 2021

Description

In the function schechter_lf rename the keyword argument noise to shot_noise. Breaking API change to be considered for 1.0 release. Requires deprecation warnings before merging. Resolves #478

Checklist

  • Follow the Contributor Guidelines
  • Write unit tests
  • Write documentation strings
  • Assign someone from your working team to review this pull request
  • Assign someone from the infrastructure team to review this pull request

@rrjbca rrjbca added documentation Improvements or additions to documentation enhancement Improvement of existing feature module: galaxies low priority labels Aug 31, 2021
@rrjbca rrjbca added this to the Version 1.0 milestone Aug 31, 2021
@rrjbca rrjbca requested review from a team August 31, 2021 09:06
@rrjbca rrjbca changed the title ENH: Rename keyword argument noise to shot_noise API: Rename keyword argument noise to shot_noise Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement Improvement of existing feature low priority module: galaxies
Projects
None yet
Milestone
Version 1.0
Development

Successfully merging this pull request may close these issues.

ENH: Rename noise keyword argument in redshifts_from_comoving_density function
1 participant
@rrjbca