Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #827 #907 #908 #901, add compress operator and encrypt operator #906

Closed
wants to merge 13 commits into from
Closed

Fix #827 #907 #908 #901, add compress operator and encrypt operator #906

wants to merge 13 commits into from

Conversation

killerdbob
Copy link
Contributor

@killerdbob killerdbob mentioned this pull request Aug 4, 2023
Open
@killerdbob
Copy link
Contributor Author

fix #827,

@killerdbob killerdbob changed the title create compress operator and encrypt operator Fix #827, add compress operator and encrypt operator Aug 4, 2023
@killerdbob
Copy link
Contributor Author

commit ae9a422, fix #908

@killerdbob killerdbob changed the title Fix #827, add compress operator and encrypt operator Fix #827 #907 #908 #, add compress operator and encrypt operator Aug 4, 2023
@killerdbob killerdbob changed the title Fix #827 #907 #908 #, add compress operator and encrypt operator Fix #827 #907 #908 , add compress operator and encrypt operator Aug 4, 2023
@killerdbob killerdbob changed the title Fix #827 #907 #908 , add compress operator and encrypt operator Fix #827 #907 #908 #901, add compress operator and encrypt operator Aug 4, 2023
@sarahwooders sarahwooders self-requested a review August 4, 2023 18:45
sarahwooders
sarahwooders requested changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@sarahwooders sarahwooders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to remove the advanced planner portions of your commit? I think it would be easier to track changes if we made one major change at a time, and the new planners will also need more extensive testing.

Also, could you please make sure all the tests pass in the check?

@killerdbob
Copy link
Contributor Author

ok, I will open another thread.

Would it be possible to remove the advanced planner portions of your commit? I think it would be easier to track changes if we made one major change at a time, and the new planners will also need more extensive testing.

Also, could you please make sure all the tests pass in the check?

@killerdbob killerdbob closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahwooders sarahwooders sarahwooders requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@killerdbob @sarahwooders @lynnliu030