mixins working with custom protected registry #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skypjack
requested changes
Feb 21, 2025
| template<typename Entity> | ||
| struct basic_custom_registry: entt::basic_registry<Entity> {}; | ||
| class basic_custom_registry: protected entt::basic_registry<Entity> { | ||
| using registry_type = entt::basic_registry<Entity>; |
There was a problem hiding this comment.
There is a clang-format file in EnTT. Please, use it also for these changes. 🙏🙂
| @@ -130,7 +130,12 @@ class basic_sigh_mixin final: public Type { | |||
| } | |||
|
|
|||
| void bind_any(any value) noexcept final { | |||
| owner = internal::any_to_owner<registry_type>(value); | |||
| if(auto *registry = any_cast<owner_type>(&value)) { | |||
There was a problem hiding this comment.
I'd rather change the code of any_to_owner than duplicate the logic in two places.
Also, I agree that reinterpret_cast is a no-go. Probably a static_cast is more than enough and slightly safer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working but.. not-confident-about-the-whole-thing addressing #1222
The issue is I don't quite like this reinterpret_cast there
What I don't quite understand, is that both the if statements get hit
basic_registryconstructor when callingrebind. How come any_cast detects the custom registry?assure(let's say from.emplace<Component>from the custom registry, assuming it was exposed), the newly created pool binding hits the second if and the reinterpret_cast is needed.