[db] only query for specific fields of requests #7658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/smoke-test --kubernetes --no-resource-heavy https://buildkite.com/skypilot-1/smoke-tests/builds/4575 |
SeungjinYang
force-pushed
the
request-db-optimizations-4
branch
from
f946837 to
5dbdd3d
Compare
SeungjinYang
force-pushed
the
request-db-optimizations-4
branch
from
a2efe80 to
c6fda18
Compare
Collaborator
Author
|
/quicktest-core --base-branch v0.10.1 |
5 tasks
SeungjinYang
force-pushed
the
request-db-optimizations-4
branch
2 times, most recently
from
ed6c773 to
4ac465f
Compare
SeungjinYang
force-pushed
the
request-db-optimizations-4
branch
from
4ac465f to
0606a01
Compare
DanielZhangQD
approved these changes
Oct 20, 2025
Collaborator
DanielZhangQD
left a comment
DanielZhangQD
left a comment
There was a problem hiding this comment.
LGTM! Thanks! @SeungjinYang
Collaborator
Author
|
/quicktest-core --base-branch v0.10.1 |
kevinmingtarja
pushed a commit
that referenced
this pull request
Oct 21, 2025
* only query for specific fields * fix ut * apply the same trick to individual request gets * fix UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RequestTaskFilter had fields parameter introduced some days ago. This PR adds appropriate fields parameter to callers that do not need all of the parameters (especially request / response bodies) to perform their tasks.
Also does the same thing for get functions for a single request.
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)