Skip to content

Conversation

@lloyd-brown
Copy link
Collaborator

@lloyd-brown lloyd-brown commented Oct 9, 2025

In #7406 we introduced showing the user the replica their job is assigned to on job launch. Upon further thought there are a couple issue with this:

  1. A job may not get assigned immediately in the case that a pool is exhausted or provisioning, in this case this logic doesn't display anything which is not ideal.
  2. When we are launching a large number of jobs with --num-jobs we get many messages which is poor UX.

Instead we remove this logic and don't display on jobs launch, but we add logic to sky jobs queue to display the worker assignment. We do this by adding a call to pool status in sky jobs queue that we perform in parallel to our managed_jobs.queue() call. The result looks like this:
image

I added a smoke test to make sure we display this in sky jobs queue.

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@lloyd-brown lloyd-brown changed the title Fix worker assignment. [Pools] Cleaner Worker Assignment UX Oct 9, 2025
@lloyd-brown lloyd-brown marked this pull request as ready for review October 9, 2025 18:44
@lloyd-brown
Copy link
Collaborator Author

/smoke-test

@lloyd-brown lloyd-brown requested a review from cblmemo October 9, 2025 23:03
@lloyd-brown
Copy link
Collaborator Author

/smoke_test -k test_pools

@lloyd-brown
Copy link
Collaborator Author

/smoke-test

@lloyd-brown lloyd-brown force-pushed the lloyd/change-worker-assignment branch from 5e8c6c0 to c611ca2 Compare October 24, 2025 18:19
@lloyd-brown lloyd-brown force-pushed the lloyd/change-worker-assignment branch from 116149b to ae857a4 Compare October 24, 2025 20:08
@lloyd-brown
Copy link
Collaborator Author

/smoke_test

@lloyd-brown
Copy link
Collaborator Author

/smoke-test

@lloyd-brown
Copy link
Collaborator Author

/quicktest-core

@lloyd-brown lloyd-brown merged commit b59c872 into master Oct 24, 2025
22 checks passed
@lloyd-brown lloyd-brown deleted the lloyd/change-worker-assignment branch October 24, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants