Skip to content

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented Oct 9, 2025

After enabling consolidation mode, user needs to restart the API server to:

  1. get the job refresh deamon
  2. get the correct number of API server executors (since this will not be the same for consolidation mode)

This PR adds a signal file to indicating this restart process and print out warnings for user to restart the api server.

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@cblmemo cblmemo requested a review from cg505 October 9, 2025 17:57
@cblmemo
Copy link
Collaborator Author

cblmemo commented Oct 9, 2025

/smoke-test --managed-jobs
/quicktest-core

@cg505 cg505 requested a review from kevinmingtarja October 9, 2025 18:30
Copy link
Collaborator

@cg505 cg505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Can we add a smoke test checking that the warning gets printed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants