Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peoetry-build.yml to ensure github CI pass #4541

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

zpoint
Copy link
Collaborator

@zpoint zpoint commented Jan 7, 2025

2 days ago, poetry 2.0 release with this update:

Change the default behavior of poetry lock to --no-update and introduce a --regenerate option for the old default behavior (python-poetry/poetry#9327).
Remove support for x in version constraints (python-poetry/poetry-core#770).

Update our config file to catch up with the poetry ensure our CI check success.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@zpoint zpoint changed the title change the dependencies of peoetry-build.yml check Update peoetry-build.yml to ensure github CI pass Jan 7, 2025
@Michaelvll
Copy link
Collaborator

How about we just get rid of the test? See: #4535 (comment)

@zpoint
Copy link
Collaborator Author

zpoint commented Jan 7, 2025

Sounds good. I thought we needed it for a reason.

@zpoint
Copy link
Collaborator Author

zpoint commented Jan 7, 2025

Removed @Michaelvll

@zpoint zpoint merged commit bee4647 into skypilot-org:master Jan 8, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants