Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Bug fix for #184, #192 #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HwangTaehyun
Copy link

@HwangTaehyun HwangTaehyun commented Jun 28, 2020

This resolves #184 and resolves #192.

I encountered the same bug as Issue #184, #192, so I created this PR.
There seems to have been some changes in response for leetcode test api (https://leetcode.com/problems/$slug/interpret_solution).

  • leetcode test url's response doesn't have "interpret_expected_id" key any more.
  • leetcode verify url's response have test's expected results (ex. expected_code_answer entry)
    • {"status_code": 10, "lang": "cpp", "run_success": true, "status_runtime": "4 ms", "memory": 6404000, "code_answer": ["[]"], "code_output": [], "elapsed_time": 14, "task_finish_time": 1593372439205, "expected_status_code": 10, "expected_lang": "cpp", "expected_run_success": true, "expected_status_runtime": "4", "expected_memory": 6480000, "expected_code_answer": ["[0,1]"], "expected_code_output": [], "expected_elapsed_time": 10, "expected_task_finish_time": 1593372309445, "correct_answer": false, "total_correct": null, "total_testcases": null, "runtime_percentile": null, "status_memory": "6.4 MB", "memory_percentile": null, "pretty_lang": "C++", "submission_id": "runcode_1593372438.5439272_GcikNkRPuF", "status_msg": "Accepted", "state": "SUCCESS"}

- Bug fix for test command freezing issue
  - There seems to have been some changes in response for leetcode test api.
    - leetcode test url's response doesn't have "interpret_expected_id"
    - leetcode verify url's response have test's expected results (ex. expected answer)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"leetcode test" doesn't work anymore How to test command?
1 participant