Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve logic on save file dmsgcurl #242

Merged
merged 10 commits into from
Dec 10, 2023
Merged

improve logic on save file dmsgcurl #242

merged 10 commits into from
Dec 10, 2023

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Nov 29, 2023 •
edited
Loading

Fixes #192

Changes:

  • remove stdout flag and make stdout mode as default dmsgcurl
  • add -r flag for save new file on exist one

How to test this PR:

@0pcom
Copy link
Collaborator

0pcom commented Dec 9, 2023

it seems that the -n --stdout flag isn't working because of an error thrown by the default output path . already exists

@mrpalide mrpalide changed the title Feat/improve path logic on save file dmsgcurl improve logic on save file dmsgcurl Dec 10, 2023
@0pcom 0pcom merged commit e12c29a into skycoin:develop Dec 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrpalide @0pcom