Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dmsgcurl #238

Merged
merged 5 commits into from
Nov 11, 2023
Merged

dmsgcurl #238

merged 5 commits into from
Nov 11, 2023

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Oct 17, 2023 •
edited
Loading

Fixes #230

Changes:

  • remove dmsgget and dmsgpost app
  • create dmsgcurl that is combine of dmsgget and dmsgpost

How to test this PR:

  • build on this branch
  • follow dmsgcurl docs.

@mrpalide mrpalide changed the base branch from master to develop October 17, 2023 03:07
This was referenced Oct 18, 2023
Merged
Merged
@mrpalide
Copy link
Contributor Author

mrpalide commented Oct 18, 2023 •
edited
Loading

skywire work as well as by update dmsg on this PR: skycoin/skywire#1663
skywire-services work as well as by update dmsg on this PR: skycoin/skywire-services#31

jdknives
jdknives approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. How can I test the POST requests working? How did you test it?

jdknives
jdknives reviewed Nov 11, 2023
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Handled base case well enough. Will merge.

@jdknives jdknives merged commit 3c042d8 into skycoin:develop Nov 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reimplment curl-like features over dmsg
2 participants
@mrpalide @jdknives