Add in the Japanese translations to the release branch.

.github/workflows/android.yml

@@ -12,11 +12,12 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: set up JDK
-      uses: actions/setup-java@v1
+      uses: actions/setup-java@v4
       with:
-        java-version: 11
+        distribution: 'zulu' # See 'Supported distributions' for available options
+        java-version: '12'
     - name: Grant execute permission for gradlew
       run: chmod +x gradlew
     - name: Build with Gradle
@@ -25,20 +26,25 @@ jobs:
       uses: asadmansr/[email protected]
       if: ${{ always() }} # IMPORTANT: run Android Test Report regardless
   connected_test:
-    runs-on: macos-latest
+    runs-on: ubuntu-latest
     strategy:
       matrix:
         api-level: [ 29 ]
         target: [ playstore ]
     steps:
       - name: checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
+      - name: Enable KVM
+        run: |
+          echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules
+          sudo udevadm control --reload-rules
+          sudo udevadm trigger --name-match=kvm
 
       - name: Setup Java
-        uses: actions/setup-java@v2
+        uses: actions/setup-java@v4
         with:
-          java-version: 11
-          distribution: 'adopt'
+          distribution: 'zulu' # See 'Supported distributions' for available options
+          java-version: '17'
 
       - name: run tests
         uses: reactivecircus/android-emulator-runner@v2

app/build.gradle

@@ -6,14 +6,14 @@ plugins {
 }
 
 android {
-    compileSdkVersion 31
+    compileSdkVersion 33
 
     defaultConfig {
         applicationId "com.google.android.stardroid"
         minSdkVersion 26
-        targetSdkVersion 31
-        versionCode 1541
-        versionName "1.10.1 - RC1"
+        targetSdkVersion 33
+        versionCode 1549
+        versionName "1.10.3 - RC1"
         buildConfigField 'String', 'GOOGLE_ANALYTICS_CODE', '""'
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }

app/src/main/java/com/google/android/stardroid/StardroidApplication.kt

@@ -40,38 +40,33 @@ import javax.inject.Inject
  * @author John Taylor
  */
 class StardroidApplication : Application() {
-  @JvmField
   @Inject
-  var preferences: SharedPreferences? = null
+  lateinit var preferences: SharedPreferences
 
   // We keep a reference to this just to start it initializing.
-  @JvmField
   @Inject
-  var layerManager: LayerManager? = null
+  lateinit var layerManager: LayerManager
 
-  @JvmField
   @Inject
-  var analytics: AnalyticsInterface? = null
+  lateinit var analytics: AnalyticsInterface
 
-  @JvmField
   @Inject
+  @JvmField
   var sensorManager: SensorManager? = null
 
   // We need to maintain references to this object to keep it from
   // getting gc'd.
-  @JvmField
   @Inject
-  var preferenceChangeAnalyticsTracker: PreferenceChangeAnalyticsTracker? = null
-  var applicationComponent: ApplicationComponent? = null
-    private set
+  lateinit var preferenceChangeAnalyticsTracker: PreferenceChangeAnalyticsTracker
+
+  val applicationComponent: ApplicationComponent = DaggerApplicationComponent.builder()
+    .applicationModule(ApplicationModule(this))
+    .build()
 
   override fun onCreate() {
     Log.d(TAG, "StardroidApplication: onCreate")
     super.onCreate()
-    applicationComponent = DaggerApplicationComponent.builder()
-      .applicationModule(ApplicationModule(this))
-      .build()
-    applicationComponent?.inject(this)
+    applicationComponent.inject(this)
     Log.i(
       TAG, "OS Version: " + Build.VERSION.RELEASE
           + "(" + Build.VERSION.SDK_INT + ")"
@@ -88,27 +83,27 @@ class StardroidApplication : Application() {
   }
 
   private fun setUpAnalytics(versionName: String) {
-    (analytics ?: return).setEnabled((preferences ?: return).getBoolean(AnalyticsInterface.PREF_KEY, true))
+    analytics.setEnabled(preferences.getBoolean(AnalyticsInterface.PREF_KEY, true))
 
     // Ugly hack since this isn't injectable
     PreferencesButton.setAnalytics(analytics)
-    var previousVersion = preferences?.getString(PREVIOUS_APP_VERSION_PREF, NONE)
+    var previousVersion = preferences.getString(PREVIOUS_APP_VERSION_PREF, NONE)
     var newUser = false
     if (previousVersion == NONE) {
       // It's possible a previous version exists, it's just that it wasn't a recent enough
       // version to have set PREVIOUS_APP_VERSION_PREF.  If so, we should see that the TOS
       // have been accepted.
       val oldPreviousVersionKey = "read_tos"
-      if (preferences!!.contains(oldPreviousVersionKey)) {
+      if (preferences.contains(oldPreviousVersionKey)) {
         previousVersion = UNKNOWN
       } else {
         // Best guess that this is the first every run of a new user.
         // Could also be someone with a new device.
         newUser = true
       }
     }
-    analytics?.setUserProperty(AnalyticsInterface.NEW_USER, java.lang.Boolean.toString(newUser))
-    preferences!!.edit().putString(PREVIOUS_APP_VERSION_PREF, versionName).apply()
+    analytics.setUserProperty(AnalyticsInterface.NEW_USER, java.lang.Boolean.toString(newUser))
+    preferences.edit().putString(PREVIOUS_APP_VERSION_PREF, versionName).apply()
     if (previousVersion != versionName) {
       // It's either an upgrade or a new installation
       Log.d(TAG, "New installation: version $versionName")
@@ -118,13 +113,13 @@ class StardroidApplication : Application() {
     // It will be interesting to see *when* people use Sky Map.
     val b = Bundle()
     b.putInt(AnalyticsInterface.START_EVENT_HOUR, Calendar.getInstance()[Calendar.HOUR_OF_DAY])
-    analytics?.trackEvent(AnalyticsInterface.START_EVENT, b)
-    preferences!!.registerOnSharedPreferenceChangeListener(preferenceChangeAnalyticsTracker)
+    analytics.trackEvent(AnalyticsInterface.START_EVENT, b)
+    preferences.registerOnSharedPreferenceChangeListener(preferenceChangeAnalyticsTracker)
   }
 
   override fun onTerminate() {
     super.onTerminate()
-    analytics?.setEnabled(false)
+    analytics.setEnabled(false)
   }// TODO(jontayler): update to use the info created by gradle.
 
   /**
@@ -165,7 +160,9 @@ class StardroidApplication : Application() {
   private fun performFeatureCheck() {
     if (sensorManager == null) {
       Log.e(TAG, "No sensor manager")
-      analytics?.setUserProperty(AnalyticsInterface.DEVICE_SENSORS, AnalyticsInterface.DEVICE_SENSORS_NONE)
+      analytics.setUserProperty(
+        AnalyticsInterface.DEVICE_SENSORS, AnalyticsInterface.DEVICE_SENSORS_NONE
+      )
       return
     }
     // Reported available sensors
@@ -184,7 +181,7 @@ class StardroidApplication : Application() {
     }
 
     // TODO: Change to String.join once we're at API > 26
-    analytics?.setUserProperty(
+    analytics.setUserProperty(
       AnalyticsInterface.DEVICE_SENSORS, TextUtils.join("|", reportedSensors)
     )
 
@@ -207,8 +204,8 @@ class StardroidApplication : Application() {
     }
 
     // Enable Gyro if available and user hasn't already disabled it.
-    if (!preferences!!.contains(ApplicationConstants.SHARED_PREFERENCE_DISABLE_GYRO)) {
-      preferences!!.edit().putBoolean(
+    if (!preferences.contains(ApplicationConstants.SHARED_PREFERENCE_DISABLE_GYRO)) {
+      preferences.edit().putBoolean(
         ApplicationConstants.SHARED_PREFERENCE_DISABLE_GYRO, !hasRotationSensor
       ).apply()
     }
@@ -217,7 +214,7 @@ class StardroidApplication : Application() {
     Log.d(TAG, "All sensors:")
     val allSensors = sensorManager?.getSensorList(Sensor.TYPE_ALL)
     val sensorTypes: MutableSet<String> = HashSet()
-    for (sensor in allSensors?: emptyList()) {
+    for (sensor in allSensors ?: emptyList()) {
       Log.i(TAG, sensor.name)
       sensorTypes.add(getSafeNameForSensor(sensor))
     }
@@ -242,7 +239,7 @@ class StardroidApplication : Application() {
       dummy, sensor, SensorManager.SENSOR_DELAY_UI
     ) ?: false
     if (!success) {
-      analytics?.setUserProperty(AnalyticsInterface.SENSOR_LIAR, "true")
+      analytics.setUserProperty(AnalyticsInterface.SENSOR_LIAR, "true")
     }
     sensorManager?.unregisterListener(dummy)
     return success
@@ -258,8 +255,6 @@ class StardroidApplication : Application() {
      * Returns either the name of the sensor or a string version of the sensor type id, depending
      * on the supported OS level along with some context.
      */
-    fun getSafeNameForSensor(sensor: Sensor): String {
-      return  "Sensor type: ${sensor.stringType}: ${sensor.type}"
-    }
+    fun getSafeNameForSensor(sensor: Sensor) = "Sensor type: ${sensor.stringType}: ${sensor.type}"
   }
 }

app/src/main/java/com/google/android/stardroid/activities/dialogs/TimeTravelDialog.java

@@ -244,21 +244,14 @@ private void setPopularDate(int popularDateIndex) {
         // http://mainfacts.com/timestamp-date-converter-calculator
         setDate(new Date(1462805846000L));
         break;
-      case 5: // Solar Eclipse 2017 North America.
+      case 5: // Solar Eclipse 2024 North America.
         // Source: http://mainfacts.com/timestamp-date-converter-calculator
-        setDate(new Date(1503340380000L));
+        setDate(new Date(1712604000000L));
         break;
-      case 6: // Solar Eclipse 2016.
-        // Source: http://mainfacts.com/timestamp-date-converter-calculator
-        setDate(new Date(1457489160000L));
-        break;
-      case 7: // Solar Eclipse 1919.
-        setDate(new Date(-1596619190000L));
-        break;
-      case 8:  // Moon Landing 1969.
+      case 6:  // Moon Landing 1969.
         setDate(new Date(-14182953622L));
         break;
-      case 9:  // 2020 Saturn/Jupiter conjunction
+      case 7:  // 2020 Saturn/Jupiter conjunction
         setDate(new Date(1608574800000L));
         break;
       default:

app/src/main/java/com/google/android/stardroid/search/SearchTermsProvider.kt

@@ -33,9 +33,9 @@ import javax.inject.Inject
 class SearchTermsProvider : ContentProvider() {
   data class SearchTerm(var query: String, var origin: String)
 
-  @JvmField
   @Inject
-  var layerManager: LayerManager? = null
+  lateinit var layerManager: LayerManager
+
   override fun onCreate(): Boolean {
     maybeInjectMe()
     return true
@@ -50,7 +50,7 @@ class SearchTermsProvider : ContentProvider() {
       return true
     }
     val appContext = context?.applicationContext as? StardroidApplication ?: return false
-    val component = appContext.applicationComponent ?: return false
+    val component = appContext.applicationComponent
     component.inject(this)
     alreadyInjected = true
     return true
@@ -83,7 +83,7 @@ class SearchTermsProvider : ContentProvider() {
     if (query == null) {
       return cursor
     }
-    val results = layerManager!!.getObjectNamesMatchingPrefix(query)
+    val results = layerManager.getObjectNamesMatchingPrefix(query)
     Log.d("SearchTermsProvider", "Got results n=" + results.size)
     for (result in results) {
       cursor.addRow(columnValuesOfSuggestion(result))