Repository navigation
Add bounds-checking to strat and strat! - #269
Merged
Merged
Conversation
This commit adds bound-checking for heap-allocated strings for the `strat` and `strat!` functions. However I realized that it doesn't work for static/inline strings as they are not prefixed with a header.
Because static strings aren't heap-allocated (d'oh) they don't have the secret header prefixed so we can't test their bounds. Add a fake header. Add a method for getting the size of strings to make sure it works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request closes #268 by adding bounds-checking to the
stratandstrat!functions.This was more annoying that I'd like because of course not all strings are heap-allocated. Something like:
Has a string which is staticly allocated, and not heap-based. That means that my original plan to use the "secret" header prefixed to all heap-allocations as a means of determining the length of the memory was doomed... To resolve this I added a fake-header to all static strings too, which means they can now be treated identically.
I added an internal methoed
alento return allocation lengths too for neatness, though it is undocumented.