Added new Alps SKDN Brown #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skwee357
requested changes
Sep 12, 2023
Owner
skwee357
left a comment
skwee357
left a comment
There was a problem hiding this comment.
Can you provide a link to the switch datasheet / online store where it's sold?
Comment on lines
+22
to
+23
| upper: Material.Unspecified(Color.Opaque(COLOR_OTHER)), | ||
| lower: Material.Unspecified(Color.Opaque(COLOR_OTHER)), |
Owner
There was a problem hiding this comment.
Not sure where COLOR_OTHER is defined
Comment on lines
+12
to
+13
| stem: 'alps mount', | ||
| mount: 'alps', |
Owner
There was a problem hiding this comment.
You will have to define ALPS stem, as I haven't defined it yet
Owner
There was a problem hiding this comment.
Please see how I did it for MX stem
| @@ -0,0 +1,7 @@ | |||
| import { Brand } from '../../../switch'; | |||
| import jadeGreen62g from './SKDN'; | |||
Owner
There was a problem hiding this comment.
Suggested change
| import jadeGreen62g from './SKDN'; | |
| import skdn from './SKDN'; |
|
|
||
| export default { | ||
| name: 'Alps', | ||
| switches: [SKDN], |
Owner
There was a problem hiding this comment.
Suggested change
| switches: [SKDN], | |
| switches: [skdn], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new Alps SKDN switch to Database.