More responsive target configuration by checking pod status

skupperproject · Jan 18, 2021 · fea613d · fea613d
1 parent 1507879
commit fea613d
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/cmd/service-controller/bridges.go b/cmd/service-controller/bridges.go
@@ -14,6 +14,7 @@ import (
 	"k8s.io/client-go/tools/cache"
 
 	"github.com/skupperproject/skupper/api/types"
+	"github.com/skupperproject/skupper/pkg/kube"
 	"github.com/skupperproject/skupper/pkg/qdr"
 )
 
@@ -278,8 +279,12 @@ func (eb *EgressBindings) updateBridgeConfiguration(protocol string, address str
 		pods := eb.informer.GetStore().List()
 		for _, p := range pods {
 			pod := p.(*corev1.Pod)
-			log.Printf("Adding pod for %s: %s", address, pod.ObjectMeta.Name)
-			addEgressBridge(protocol, pod.Status.PodIP, eb.egressPort, address, eb.name, siteId, "", bridges)
+			if kube.IsPodRunning(pod) && kube.IsPodReady(pod) && pod.DeletionTimestamp == nil {
+				log.Printf("Adding pod for %s: %s", address, pod.ObjectMeta.Name)
+				addEgressBridge(protocol, pod.Status.PodIP, eb.egressPort, address, eb.name, siteId, "", bridges)
+			} else {
+				log.Printf("Pod for %s not ready/running: %s", address, pod.ObjectMeta.Name)
+			}
 		}
 	} else if eb.service != "" {
 		addEgressBridge(protocol, eb.service, eb.egressPort, address, eb.name, siteId, eb.service, bridges)