prevent nil pointer dereference on renaming attempt

skupperproject · Mar 11, 2021 · 3981b08 · 3981b08
1 parent 992de5d
commit 3981b08
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/client/router_update.go b/client/router_update.go
@@ -130,7 +130,9 @@ func (cli *VanClient) RouterUpdateVersionInNamespace(ctx context.Context, hup bo
 		if err != nil && !errors.IsAlreadyExists(err) {
 			return false, err
 		}
-		consoleUsesLoadbalancer = controllerSvc.Spec.Type == corev1.ServiceTypeLoadBalancer
+		if controllerSvc != nil {
+			consoleUsesLoadbalancer = controllerSvc.Spec.Type == corev1.ServiceTypeLoadBalancer
+		}
 		//update annotation on skupper-router-console if it exists
 		routerConsoleService, err := cli.KubeClient.CoreV1().Services(namespace).Get(types.RouterConsoleServiceName, metav1.GetOptions{})
 		if err == nil {