Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1536: Removed unnecessary check for n >= 0 #1537

Closed
wants to merge 1 commit into from

Conversation

ganeshmurthy
Copy link
Contributor

No description provided.

@ganeshmurthy ganeshmurthy linked an issue Jun 24, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.5%. Comparing base (1b1d4b9) to head (033d808).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1537      +/-   ##
========================================
+ Coverage   63.0%   77.5%   +14.5%     
========================================
  Files        214      65     -149     
  Lines      51857   16389   -35468     
  Branches    5986       0    -5986     
========================================
- Hits       32681   12705   -19976     
+ Misses     16966    3684   -13282     
+ Partials    2210       0    -2210     
Flag Coverage Δ
pysystemtests 77.5% <ø> (-0.8%) ⬇️
systemtests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
unittests 77.5% <31.5%> (+14.5%) ⬆️
systemtests 77.5% <31.5%> (-0.8%) ⬇️

@jiridanek
Copy link
Contributor

Took a look at the failing CI and reported

@jiridanek
Copy link
Contributor

@jiridanek jiridanek closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverity issue: Checking if unsigned number is >= 0
2 participants